feat(contracts): seed the pattern registry and check headings - #296
Merged
Conversation
Keep the 40 pattern bodies in Markdown and fail CI when headings, severity-table IDs, or the frontmatter count drift from patterns.json. Refs #278 Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Raise patch coverage for heading, severity-table, and missing-registry errors so the Codecov patch check can pass. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/document-intelligence/patterns.jsonfor all 40 core patterns (id, severity, domain applicability, mode carve-outs, trigger terms, false-positive guards). Pattern 27 staysmust_preserve.src/modules/SKILL_CORE_PATTERNS.mdheadings, body severities, severity-table IDs, and the frontmatterpatternscount. Duplicate Low-tier IDs now failnpm run validate:contracts.compile-skill.jsalone in this pass. Pattern bodies stay in Markdown.Test plan
node --test test/skill-contracts.test.jsnode scripts/validate-skill-contracts.jstest,validate-skill, andportable-specgreenRefs #278